Update cache key for composer dependencies #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achyuthajoy
added
focus: devops
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
alopezari
reviewed
Oct 28, 2024
| @@ -30,7 +30,7 @@ runs: | |||
| uses: actions/cache@v4 | |||
| with: | |||
| path: ./vendor | |||
There was a problem hiding this comment.
This line hasn't been changed in this PR, but should we take the advantage to update the path value from this workflow to ~/.cache/composer/ to match the others? This is the only one using vendor, and I've read that caching the global composer cache is considered a good practice, and seems to be more efficient in terms of space.
There was a problem hiding this comment.
@alopezari On E2E tests env setup action we cache the vendor directory because we're caching the installed dependencies where as rest of the workflows cache the package files downloaded by composer but they need run composer install.
The cache handling for E2E setup prevents running composer install and restores the whole vendor directory, but rest of the workflows are not configured this way. We can look at unifying this as another task. WDYT?
alopezari
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for implementing this change and following up on my question, @achyuthajoy!
Approving this PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9478
Changes proposed in this Pull Request
composer.json&composer.lock.composer.jsonwas updated.Testing instructions
Linux-composer-<composer.json-hash>-<composer.lock-hash>in the GitHub actions logs. Previously it wasLinux-composer-<composer.lock-hash>.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge