Add support for allowedShippingCountries in Express Checkout Element #9592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +44 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Don’t send the full country list in the two cases where all countries would be sent
asumaran
force-pushed
the
9104-add-support-for-allowedshippingcountries-in-express-checkout-element
branch
from
f3552d8
to
606ec49
Compare
asumaran
commented
Oct 20, 2024
includes/express-checkout/class-wc-payments-express-checkout-button-handler.php
Outdated
Show resolved
Hide resolved
…ries-in-express-checkout-element
asumaran
requested review from
a team and
rafaelzaleski
and removed request for
a team
rafaelzaleski
approved these changes
Oct 29, 2024
asumaran
deleted the
9104-add-support-for-allowedshippingcountries-in-express-checkout-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #9104
Changes proposed in this Pull Request
Adds support for specifying allowed shipping countries (
allowedShippingCountries) in the Express Checkout Element.Testing instructions
Tip
If you want to test with multiple addresses from different countries, you can add yourself to the Google test card suite group. In test mode, you’ll have access to a set of test cards, rather than the cards associated with your production account.
https://developers.google.com/pay/api/web/guides/resources/test-card-suite
Note
To test the changes introduced here, we first need to create shipping options for at least two countries. In this case the countries will be USA and Brazil. You can create a "Flat rate" shipping method for both countries. That will be sufficient.
Note
The test results should be the same for all the pages affected by this PR: Product Page, Cart Page, Checkout Page, Cart shortcode, and Checkout shortcode. (Does not apply to the "Pay for Order" page.)
Note
All cases should be tested in the same way:
Note
Since this PR includes many combinations to test, and given that ECE has two different implementations, I would suggest testing at least the Checkout (block) page and the Shortcode Checkout page. That would cover both ECE implementations currently in WooPayments.
Important
Test with Apple Pay on at least the pages mentioned above. The results should be the same for each test.
Case 1: "Shipping location(s)" is set to "Ship to all countries you sell to"
Case 2: "Shipping location(s)" is set to "Ship to all countries"
This option ignores the value set in "Selling location(s)", therefore:
Case 3: "Shipping location(s)" is set to "Ship to specific countries only" and "Ship to specific countries" is set to "Brazil"
Potential Issues:
If, during testing, you find that you can’t open the payment sheet and see the following error in the browser console:
This is a known issue and has been reported here. One way to fix it is by clearing all cookies and starting again. Another way is to go to the checkout page and change the shipping address to a country with shipping options, such as the USA or Brazil.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge