remove redundant null default

Automattic · Nov 8, 2024 · d3a6bc0 · d3a6bc0
1 parent 2062258
commit d3a6bc0
Show file tree

Hide file tree

Showing 14 changed files with 15 additions and 14 deletions.
diff --git a/includes/payment-methods/class-affirm-payment-method.php b/includes/payment-methods/class-affirm-payment-method.php
@@ -44,7 +44,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-afterpay-payment-method.php b/includes/payment-methods/class-afterpay-payment-method.php
@@ -74,7 +74,7 @@ public function get_icon( string $account_country = null ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-bancontact-payment-method.php b/includes/payment-methods/class-bancontact-payment-method.php
@@ -39,7 +39,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-becs-payment-method.php b/includes/payment-methods/class-becs-payment-method.php
@@ -39,7 +39,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return __( '<strong>Test mode:</strong> use the test account number <number>000123456</number>. Other payment methods may redirect to a Stripe test page to authorize payment. More test card numbers are listed <a>here</a>.', 'woocommerce-payments' );
 	}
 }
diff --git a/includes/payment-methods/class-cc-payment-method.php b/includes/payment-methods/class-cc-payment-method.php
@@ -71,8 +71,9 @@ public function get_title( string $account_country = null, $payment_details = fa
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		$test_card_number = Country_Test_Cards::get_test_card_for_country( $account_country );
+		$test_card_number = '4242 4242 4242 4242';
 
 		return sprintf(
 			// Translators: %s is a test card number.

diff --git a/includes/payment-methods/class-eps-payment-method.php b/includes/payment-methods/class-eps-payment-method.php
@@ -39,7 +39,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-giropay-payment-method.php b/includes/payment-methods/class-giropay-payment-method.php
@@ -39,7 +39,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-ideal-payment-method.php b/includes/payment-methods/class-ideal-payment-method.php
@@ -39,7 +39,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-klarna-payment-method.php b/includes/payment-methods/class-klarna-payment-method.php
@@ -73,7 +73,7 @@ public function get_countries() {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-link-payment-method.php b/includes/payment-methods/class-link-payment-method.php
@@ -37,7 +37,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-p24-payment-method.php b/includes/payment-methods/class-p24-payment-method.php
@@ -39,7 +39,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-sepa-payment-method.php b/includes/payment-methods/class-sepa-payment-method.php
@@ -43,7 +43,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return __( '<strong>Test mode:</strong> use the test account number <number>AT611904300234573201</number>. Other payment methods may redirect to a Stripe test page to authorize payment. More test card numbers are listed <a>here</a>.', 'woocommerce-payments' );
 	}
 }
diff --git a/includes/payment-methods/class-sofort-payment-method.php b/includes/payment-methods/class-sofort-payment-method.php
@@ -40,7 +40,7 @@ public function __construct( $token_service ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	public function get_testing_instructions( string $account_country = null ) {
+	public function get_testing_instructions( string $account_country ) {
 		return '';
 	}
 }
diff --git a/includes/payment-methods/class-upe-payment-method.php b/includes/payment-methods/class-upe-payment-method.php
@@ -273,7 +273,7 @@ public function get_payment_token_for_user( $user, $payment_method_id ) {
 	 * @param string $account_country The country of the account.
 	 * @return string
 	 */
-	abstract public function get_testing_instructions( string $account_country = null );
+	abstract public function get_testing_instructions( string $account_country );
 
 	/**
 	 * Returns the payment method icon URL or an empty string.