fix(dev-tools): grant privileges to MySQL users properly #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivy Scan Reportghcr.io/automattic/vip-container-images/dev-tools:0.9 (alpine 3.19.1)No vulnerabilities found. |
|
rinatkhaziev
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that
docker-compose.ymlinstructed MySQL to create the user: https://github.com/Automattic/vip-cli/blob/trunk/assets/dev-env.lando.template.yml.ejs#L99-L101As a consequence,
if ! mysql -h "$db_host" -u wordpress -pwordpress wordpress -e "SELECT 'testing_db'" >/dev/null 2>&1; thenwas always false, and we did not grant the user theSET_ANY_DEFINERprivilege.Moreover, the
GRANT ALL ON *.* TO 'netapp'@'%';caused issues later because MySQL grants all privileges to the user only on the specific database. We grantnetappall privileges on all databases, and MySQL was unhappy about it on import: "Access denied; you need (at least one of) the SYSTEM_USER privilege(s) for this operation".What has changed now:
...@localhostusers anymore: MySQL did not do that, and we probably should not either;wordpressdatabase; this corresponds to what MySQL does;SET_ANY_DEFINERprivilege by default.IF NOT EXISTSclauses guard against errors if the user or the database already exists. DuplicateGRANTstatements are harmless.