Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Up Next Shuffle] Enable the Feature for Plus and Patron only #2370

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

danielebogo
Copy link
Contributor

📘 Part of: Up Next Shuffle

This PR adds:
• The feature available for Plus and Patron user only
• Hides the shuffle button and clear button if the queue is empty
• Update Changelog

Plus Icon Default Icon Empty Screen
RocketSim_Screenshot_iPhone_16_6 1_2024-10-31_14 37 54 RocketSim_Screenshot_iPhone_16_6 1_2024-10-31_14 38 19 RocketSim_Screenshot_iPhone_16_6 1_2024-10-31_14 38 36

To test

  • CI must be 🟢
  • Run the app with the StoreKit scheme or run this PR on a real device with a sandbox account
  • Run a fresh install and log in with a non plus/patron user
  • Add few episodes in the queue
  • Go to Up Next
  • Confirm the Shuffle button gold is present
  • Clear the queue
  • Confirm both shuffle and clear button disappear from the view
  • Add few episodes again
  • Go back to Up Next
  • Tap shuffle gold
  • Confirm the paywall is presented
  • Purchase a plan
  • When the paywall is dismissed confirm the Shuffle icon is the gray one
  • Confirm tapping the shuffle doesn't promtp the paywall and enable/disable the feature

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.77 milestone Oct 31, 2024
@danielebogo danielebogo requested a review from a team as a code owner October 31, 2024 13:51
@danielebogo danielebogo requested review from bjtitus and removed request for a team October 31, 2024 13:51
@danielebogo danielebogo requested review from SergioEstevao and removed request for bjtitus October 31, 2024 20:16
@SergioEstevao
Copy link
Contributor

SergioEstevao commented Nov 1, 2024

Very edge case but when testing this when switching from a Patron account ( where I had Shuffle active) to a free account the shuffle option stayed active on the free active, and I couldn't disable it with out going trough the paywall.

I think the issue here, is that the UpNext that is part of the tab, only updates on startup, so you probably need to refresh it on logout notification.

It will also be good to reset the shuffle setting when logging out of an account so it goes to the disable state.

@SergioEstevao
Copy link
Contributor

If you open the the app, without any account installed, then create an account but without signing up for Plus or Patron the shuffle button stays inactive until I restart the app.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about logging out from an account that has Patron/Plus

@danielebogo danielebogo force-pushed the danieleb/Up-Next-Shuffle/2324-shuffle-for-plus-patron branch from 1688f0f to b239de6 Compare November 1, 2024 17:44
@danielebogo
Copy link
Contributor Author

Thansk @SergioEstevao ! The PR should be ready for another look.

If you open the the app, without any account installed, then create an account but without signing up for Plus or Patron the shuffle button stays inactive until I restart the app.

I think this is because of the FF being enabled after the view did load. I realized that this may affect the old button too

It will also be good to reset the shuffle setting when logging out of an account so it goes to the disable state.

I added the check of the user login state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants