-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Up Next Shuffle] Enable the Feature for Plus and Patron only #2370
base: trunk
Are you sure you want to change the base?
[Up Next Shuffle] Enable the Feature for Plus and Patron only #2370
Conversation
Very edge case but when testing this when switching from a Patron account ( where I had Shuffle active) to a free account the shuffle option stayed active on the free active, and I couldn't disable it with out going trough the paywall. I think the issue here, is that the UpNext that is part of the tab, only updates on startup, so you probably need to refresh it on logout notification. It will also be good to reset the shuffle setting when logging out of an account so it goes to the disable state. |
If you open the the app, without any account installed, then create an account but without signing up for Plus or Patron the shuffle button stays inactive until I restart the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments about logging out from an account that has Patron/Plus
1688f0f
to
b239de6
Compare
Thansk @SergioEstevao ! The PR should be ready for another look.
I think this is because of the FF being enabled after the view did load. I realized that this may affect the old button too
I added the check of the user login state |
This PR adds:
• The feature available for Plus and Patron user only
• Hides the shuffle button and clear button if the queue is empty
• Update Changelog
To test
Checklist
CHANGELOG.md
if necessary.