Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback 2024: Fix indicator color in EoY 2024 Stories #2368

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Playback 2024: Fix indicator color in EoY 2024 Stories #2368

merged 2 commits into from
Oct 31, 2024
+27 −3

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Oct 31, 2024 •
edited
Loading

📘 Part of: #2367

Makes the indicator and close buttons black for Playback 2024

Before After
CleanShot 2024-10-30 at 20 49 29@2x CleanShot 2024-10-30 at 20 46 22@2x

To test

  • Enable the endOfYear2024 feature flag
  • Restart app
  • Visit Profile and tap the Playback 2024 cell
  • Ensure that indicators and close button are black

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Oct 31, 2024
@bjtitus bjtitus added this to the 7.77 milestone Oct 31, 2024
@bjtitus bjtitus requested a review from a team as a code owner October 31, 2024 02:45
@bjtitus bjtitus requested review from danielebogo and removed request for a team October 31, 2024 02:45
danielebogo
danielebogo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bjtitus bjtitus merged commit b95efd4 into trunk Oct 31, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback-2024/indicator-color branch October 31, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Milestone
7.77
Development

Successfully merging this pull request may close these issues.
2 participants
@bjtitus @danielebogo