Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Replace Subscribe with Follow #2356

Merged
merged 3 commits into from
Oct 30, 2024
Merged

[Enhancement] Replace Subscribe with Follow #2356

merged 3 commits into from
Oct 30, 2024
+95 −31

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Oct 29, 2024 •
edited
Loading

As discussed in our P2 we want to update some texts in few screens, to replace the word Subscribe with Follow

Podcast Page Podcast Page Unsubscribe Podcast Settings Podcast Page Unsubscribe Download
RocketSim_Screenshot_iPhone_16_6 1_2024-10-29_16 31 23 RocketSim_Screenshot_iPhone_16_6 1_2024-10-29_16 31 13 RocketSim_Screenshot_iPhone_16_6 1_2024-10-29_16 31 59 RocketSim_Screenshot_iPhone_16_6 1_2024-10-30_09 37 02
Filters All Podcast Apply Criteria Export Settings
RocketSim_Screenshot_iPhone_16_6 1_2024-10-29_16 32 27 RocketSim_Screenshot_iPhone_16_6 1_2024-10-29_16 30 55 RocketSim_Screenshot_iPhone_16_6 1_2024-10-29_16 32 44

To test

  • CI musty be 🟢
  • Run the app
  • Check the above screens
  • Switch off the FF useFollowNaming
  • Run the app to see if the changes are reverted

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Enhancement Improve an existing feature. label Oct 29, 2024
@danielebogo danielebogo added this to the 7.77 milestone Oct 29, 2024
@danielebogo danielebogo requested a review from a team as a code owner October 29, 2024 16:17
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team October 29, 2024 16:17
@SergioEstevao
Copy link
Contributor

Found this message when Unfollowing a podcast.
It says Unsubscribing on the message when you already downloaded files:

Simulator Screenshot - iPhone 16 Pro - 2024-10-29 at 21 14 35

SergioEstevao
SergioEstevao requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one screen that needs updating all the others have the updated text.

@danielebogo
Copy link
Contributor Author

nice catch @SergioEstevao ! I'll add it!

@danielebogo
Copy link
Contributor Author

@SergioEstevao ready for another look. I also added the instructions to test it with the FF

SergioEstevao
SergioEstevao approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danielebogo danielebogo merged commit d683bdb into trunk Oct 30, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/update-subscribe-to-follow branch October 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Type] Enhancement Improve an existing feature.
Projects
None yet
Milestone
7.77
Development

Successfully merging this pull request may close these issues.
2 participants
@danielebogo @SergioEstevao