-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2024: Completion Rate + Pay Wall #2350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bjtitus few things while testing:
• Tapping on the button to present the paywall doesn't do anything. It just moves to the next card
• Tapping on the left side of the last card, doesn't navigate to the previous card
• There's a different left margin in the text for this screen:
Text left margin | Video of the button not responsive and last card |
---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjtitus thanks for fixing those points.
I think there's a problem with the bottom padding in the last card
Should the bg be edge to edge?
# Conflicts: # podcasts/End of Year/End of Year 2024/EndOfYear2024StoriesModel.swift # podcasts/End of Year/End of Year 2024/EndOfYear2024Story.swift # podcasts/Strings+Generated.swift # podcasts/en.lproj/Localizable.strings
Is the percentage in the Completion Rate story in the correct place? I think it should be in the bottom right corner of the black rectangle if it fits and above it if it doesn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # podcasts/End of Year/End of Year 2024/EndOfYear2024StoriesModel.swift
Part of #2348 & #2352
Completion Rate
CompletionRate.mov
CompletionRateSmall.mov
Pay Wall
PayWall.mov
Simulator.Screen.Recording.-.iPhone.6s.-.2024-10-28.at.14.22.02.mp4
To test
Paywall
endOfYear2024
feature flag & restart the appCompletion Rate Plus
Completion Rate Patron
Checklist
CHANGELOG.md
if necessary.