Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Playback Settings] Hide segmented for local Files #2336

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2253

hides the custom playback settings for local files. As they are UserEpisode, they don't belong to a specific podcast.

To test

  • CI must be 🟢
  • Run the App
  • Open a podcast and play an episode
  • COnfirm you see the top segmented with All podcasts and This podcast
  • Change some effects for global settings
  • Go to your profile and open Files
  • Play one file
  • Confirm you don't see the top segmented
  • Confirm the global effects you changed before are applied here
  • Disable the feature flag
  • Test everything is currently working as in production and the segmented beverage appears

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.75 ❄️ milestone Oct 25, 2024
@danielebogo danielebogo requested a review from a team as a code owner October 25, 2024 10:40
@danielebogo danielebogo requested review from bjtitus and removed request for a team October 25, 2024 10:40
@danielebogo danielebogo changed the title [Custom Playback Settings] [Custom Playback Settings] Hide segmented for local Files Oct 25, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.75 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed that the segmented control is hidden for local files but still visible for podcasts.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Tested with a local video file and it worked correctly

@danielebogo danielebogo merged commit 38b44fb into release/7.75 Oct 25, 2024
5 of 8 checks passed
@danielebogo danielebogo deleted the danieleb/playback-settings-local-file branch October 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants