Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrals: Simplify sharing by just sharing text and url #2333

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Oct 24, 2024

| 📘 Part of: #2083 |
|:---:|

Fixes #

Simplify the sharing of the referral message by avoiding the duplication of the link URL.
Majority of standard system share ( Email, Message, Reminders, Notes) are able to handle the text and url as separate items so this removes the duplication of URL on the text part.

Some other systems like Instagran/Tumblr only handle the URL so no need to add the URL to the text item.

To test

  1. Start the app and login with a Plus/Patron account
  2. Ensure that you have the Referrals FF enabled
  3. Go to profile
  4. Tap on the gift icon on the top left
  5. Tap on Share guest pass
  6. Share on multiple systems and see one of the following:
    • The sharing shows the text followed by the URL, no duplication of the URL. Ex: mail, messages, reminders, WhatsApp
    • The sharing shows only the URL. Ex: Instagram

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review October 24, 2024 13:11
@SergioEstevao SergioEstevao requested a review from a team as a code owner October 24, 2024 13:11
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team October 24, 2024 13:11
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it worked! :shipit:

@SergioEstevao SergioEstevao merged commit 3e5de34 into release/7.75 Oct 24, 2024
6 of 8 checks passed
@SergioEstevao SergioEstevao deleted the referrals/improve_share branch October 24, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants