Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert FF by default #2332

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Revert FF by default #2332

merged 1 commit into from
Oct 24, 2024

Conversation

danielebogo
Copy link
Contributor

Revert the upgradeExperiment default value. It will be enabled using the Remote config

To test

  • CI must be 🟢

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.75 ❄️ milestone Oct 24, 2024
@danielebogo danielebogo requested a review from a team as a code owner October 24, 2024 12:33
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team October 24, 2024 12:33
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 24, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.75 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@danielebogo danielebogo added Feature Flag [Type] Other Issues not covered by other types, such as polish, refactoring and documentation. labels Oct 24, 2024
SergioEstevao
SergioEstevao approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danielebogo danielebogo merged commit 1edf6b8 into release/7.75 Oct 24, 2024
7 of 9 checks passed
@danielebogo danielebogo deleted the danieleb/revert-ff-default branch October 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@bjtitus bjtitus Awaiting requested review from bjtitus

Assignees
No one assigned
Labels
Feature Flag [Type] Other Issues not covered by other types, such as polish, refactoring and documentation.
Projects
None yet
Milestone
7.75
Development

Successfully merging this pull request may close these issues.
3 participants
@danielebogo @dangermattic @SergioEstevao