Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Up Next Shuffle] Add Tracks event #2329

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Oct 24, 2024

📘 Part of: Up Next Shuffle

Fixes #2328

Add up_next_shuffle_enabled tracks event

To test

  • CI must be 🟢
  • Make sure you have the FF on and tracks logger on
  • Navigate to Up next in tab
  • Tap the shuffle button to enable/disable it
  • Check 🔵 Tracked: up_next_shuffle_enabled ["source": "tab_bar", "value": VALUE] is logged
  • Navigate to Up next in modal (from the mini player)
  • Tap the shuffle button to enable/disable it
  • Check 🔵 Tracked: up_next_shuffle_enabled ["source": "mini_player", "value": VALUE] is logged
  • Navigate to Up next in modal (from the player fullscreen)
  • Tap the shuffle button to enable/disable it
  • Check 🔵 Tracked: up_next_shuffle_enabled ["source": "now_playing", "value": VALUE] is logged

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.76 milestone Oct 24, 2024
@danielebogo danielebogo marked this pull request as ready for review October 24, 2024 10:05
@danielebogo danielebogo requested a review from a team as a code owner October 24, 2024 10:05
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team October 24, 2024 10:05
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.76. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@danielebogo danielebogo merged commit 0dcea23 into danieleb/Up-Next-Shuffle/shuffle-logic Oct 24, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/Up-Next-Shuffle/add-tracks-event branch October 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants