Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Up Next Shuffle] Add shuffle and Clear buttons #2321

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Oct 22, 2024

📘 Part of: Up Next Shuffle project

Fixes #2320

This Pr adds the new shuffle button instead of the clear queue button. Also adds the Clear left navigation item instead.

Before After
Simulator Screenshot - iPhone 16 - 2024-10-22 at 18 37 17 Simulator Screenshot - iPhone 16 - 2024-10-22 at 18 36 43
Disabled with one item playing Disabled no items
Simulator Screenshot - iPhone 16 - 2024-10-22 at 18 46 44 Simulator Screenshot - iPhone 16 - 2024-10-22 at 18 46 57

To test

• CI must be 🟢
• Run the app and enable the upNextShuffle feature flag.
• Restart the app

Test Up Next in tab

• Add some items into the queue
• Navigate to Up Next
• Check you see the new buttons
• Tapping the shuffle button. Make sure the button changes states (selected/unselected).
• Make sure the button icon also updates
• Close the app and restart
• Make sure it keeps and apply the last button state
• Tap on clear to prompt the modal and clear the queue
• If there's at least one episode playing, you should see the shuffle button disabled
• re adding the new item in the queue should re-enable the button
• test multiple selection works as before
• test it also on different themes

Test Up Next swiping up

• The shuffle button behave as before
• you should not see the Clear navigation button top left, bbut the Done instead
• Do the same test as before
• test multiple selection works as before
• test it also on different themes

Test with FF off

• Switch off the FF
• re run the app
• make sure the app behaves like before

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.76 milestone Oct 22, 2024
@danielebogo danielebogo requested a review from a team as a code owner October 22, 2024 16:46
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team October 22, 2024 16:46
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found issue when updating the shuffle button on the UpNext modal view and then going back to the tab view. The state is not correctly updated.

Here is a video:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-23.at.14.45.36.mp4

@danielebogo
Copy link
Contributor Author

@SergioEstevao ready for another 👀

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.76. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :shipit:

@danielebogo danielebogo merged commit c23892d into trunk Oct 23, 2024
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/Up-Next-Shuffle/add-shuffle-button branch October 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Shuffle Button to Up Next
3 participants