-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Up Next Shuffle] Add shuffle and Clear buttons #2321
[Up Next Shuffle] Add shuffle and Clear buttons #2321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found issue when updating the shuffle button on the UpNext modal view and then going back to the tab view. The state is not correctly updated.
Here is a video:
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-23.at.14.45.36.mp4
@SergioEstevao ready for another 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Fixes #2320
This Pr adds the new shuffle button instead of the clear queue button. Also adds the Clear left navigation item instead.
To test
• CI must be 🟢
• Run the app and enable the
upNextShuffle
feature flag.• Restart the app
Test Up Next in tab
• Add some items into the queue
• Navigate to Up Next
• Check you see the new buttons
• Tapping the shuffle button. Make sure the button changes states (selected/unselected).
• Make sure the button icon also updates
• Close the app and restart
• Make sure it keeps and apply the last button state
• Tap on clear to prompt the modal and clear the queue
• If there's at least one episode playing, you should see the shuffle button disabled
• re adding the new item in the queue should re-enable the button
• test multiple selection works as before
• test it also on different themes
Test Up Next swiping up
• The shuffle button behave as before
• you should not see the Clear navigation button top left, bbut the Done instead
• Do the same test as before
• test multiple selection works as before
• test it also on different themes
Test with FF off
• Switch off the FF
• re run the app
• make sure the app behaves like before
Checklist
CHANGELOG.md
if necessary.