Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark podcasts unsynced when user changes #2198

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Sep 24, 2024

Fixes #

When switching accounts, users can lose podcast subscriptions if we don't mark podcasts as unsynced. The change in #1778 made it so that only new accounts marked all podcasts as unsynced. Instead we want to sync all podcasts any time the current account doesn't match the previous account.

To test

  • Add several podcast subscriptions
  • Login with an account
  • Ensure that all podcasts are marked as unsynced and sent via the https://api.pocketcasts.com/user/sync/update call.
  • Logout of that account
  • Login with another account
  • Ensure all podcasts are sent via the https://api.pocketcasts.com/user/sync/update call.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants