Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic type podcasts #1354

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Dynamic type podcasts #1354

wants to merge 2 commits into from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Jan 16, 2024

THIS IS AN INITIAL CONCEPT

Begins #1316

Adds UITest target + initial tests to perform accessibility audits on major tabs.

To test

Manual

  • Go to the Podcasts tab
  • Open the accessibility inspector
  • Verify that changing the preferred text size changes text appropriately

UI Test

  • Run the UI tests
  • Check for errors from the accessibility audit

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Area] Accessibility Issues related to accessibility label Jan 16, 2024
@pocketcasts
Copy link
Contributor

4 Warnings
⚠️ View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ PR is not assigned to a milestone.
⚠️ No reviewers have been set for this PR yet. Please request a review from @
Automattic/pocket-casts-ios.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Accessibility Issues related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants