Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

result.req.url for each specific simbole like space, (, ), etc... make double url encoding #288

Open
tapin13 opened this issue Oct 18, 2015 · 1 comment
Open

result.req.url for each specific simbole like space, (, ), etc... make double url encoding #288

tapin13 opened this issue Oct 18, 2015 · 1 comment

Comments

@tapin13
Copy link

tapin13 commented Oct 18, 2015

If I upload file with file name "Tux (copy).svg.72e06f3cdf16d9481d9bc1c2eb92f1d5.png",
I got URL: https://binary-options.s3.amazonaws.com/pf/Tux%2520%2528copy%2529.svg.72e06f3cdf16d9481d9bc1c2eb92f1d5.png

%2520 - is incorrect, have to be %20
jamesearl pushed a commit to BausCode/knox that referenced this issue Aug 10, 2016
fix(Automattic#288) space already handled with encodeURI
baf3257
jamesearl pushed a commit to BausCode/knox that referenced this issue Aug 10, 2016
tryfix(Automattic#288) space already handled with encodeURI, duped ca…
dbd0e4a 
…lls to encodeSpecialCharacters
jamesearl pushed a commit to BausCode/knox that referenced this issue Aug 10, 2016
fix(Automattic#288) space already handled with encodeURI, duped calls…
4dbf1f1 
… to encodeSpecialCharacters
@jamesearl
Copy link

Haven't run it through the test suite yet, but that fork ^^ has a fix that works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tapin13 @jamesearl