Feat: Add Slack social sharing #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Regarding the issue Automattic#952, compatibility of the Co-Authors Plus with Yoast Slack sharing
GaryJones
reviewed
Jul 26, 2023
- Nitpicks pointed in Automattic#953
|
@GaryJones , all done ;) |
|
Thanks! I'll give this a test, but reviewing the code against the filter looks good! |
|
These two lines appear on my local test site when the Yoast SEO feature is enabled, and the comma-separated list of names appear when there are multiple co-authors ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the Feature
To test this feature you just need to see if the following 'meta's are being inserted into the DOM head. (The Slack sharing has to be activated as described on #952