Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.6.0 #1032

Merged
merged 132 commits into from
Apr 22, 2024
Merged

Release 3.6.0 #1032

merged 132 commits into from
Apr 22, 2024

Conversation

douglas-johnson and others added 11 commits December 13, 2023 13:08
* Adds `get_authors_with_api_schema` function that returns the co-authors from the WP_REST_Server so the schema and data match the editor.
* Uses that new function in the Co-Authors Block when getting the authors for a post.
Co-authors who are WordPress users do not have a type property. So checking it to make sure they are a guest author fails.
- Switch from figure element to div to eliminate need for removing margin. Same as default WP avatar.
- Eliminated redundant display:inline, handled by parent.
- Removed alignfull and alignwide styles which are not supported.
- Updated render function to correctly support vertical-align styles.
- Updated all blocks to use apiVersion 3.
- Updated use of `Co-Authors` for consistency.
- Updated readme for consistency with block UI.
- Added block layout controls to the Co-Authors block.
- Updated Co-Authors block CSS so the default / flow layout displays co-authors in an inline style suitable for bylines.
- Added context that is passed from Co-Authors block to its descendants so controls only relevant to the inline style can be hidden when using other layouts.
- Removed support for align from the block.json file of the image and avatar blocks, instead adding it manually in the block’s edit.js so it can be omitted when using the defaut layout. When using other layouts the align controls will be removed where not applicable by `useAvailableAlignments`.
While using the site editor `outlineMode` is enabled, which can obscure the cursor when hovering over the RichText field for the prefix attribute of the Co-Authors Block. The missing cursor makes it unclear you can type in the prefix field.
Full was considered too big, especially in template editor contexts.
@alecgeatches alecgeatches self-assigned this Apr 12, 2024
@alecgeatches
Copy link
Contributor Author

@GaryJones Hello! I'm ready to wrap @douglas-johnson's #997 block changes along with a ton of maintenance tasks you've worked on since last release. Can you please take a look at the release changes and ensure they look good to you? This'll be my first release on the project. Thanks!

Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://github.com/Automattic/Co-Authors-Plus/milestone/29 there were quite a few items that were scheduled for this milestone, but I can see the advantage of wanting to get the wonderful blocks stuff out.

The only ones I would consider looking at would be #955 and #954 for this minor release, to bring us more consistency with other A8C/VIP plugins, to avoid another minor release that just updated these.

With the main focus of this release being the addition of the blocks, which doesn't really work earlier than WP 5.7, then keeping a claim of WP 4.1 doesn't make sense IMO.

Likewise, moving to PHP 7.4 (per our internal notes) as the minimum provides some developer advantages to ease maintenance, the testing setup, etc.

CHANGELOG.md Outdated
@@ -5,6 +5,31 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.6.0] - 2024-04-12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This [3.6.0] will need a corresponding markdown link entry at the bottom of this file (see existing entries already there).

The date should also be updated to when you are actually going to do the tag and release.

README.md Outdated
Comment on lines 3 to 8
Stable tag: 3.6.0
Requires at least: 4.1
Tested up to: 6.5
Requires PHP: 5.6
License: GPLv2 or later
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at c216c0d (#1032) it seems that the required double-trailing space for Markdown linebreaks have been stripped inadvertently. They should be restored.

@alecgeatches
Copy link
Contributor Author

Thank you for your feedback @GaryJones! I've made the changes you requested, and will merge this into develop today.

@alecgeatches alecgeatches merged commit 586e803 into develop Apr 22, 2024
12 checks passed
@alecgeatches alecgeatches deleted the release/3.6.0 branch April 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants