Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows assetpack download script #993

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Windows assetpack download script #993

merged 5 commits into from
Jun 26, 2024

Conversation

azaleacolburn
Copy link
Member

@azaleacolburn azaleacolburn commented Jun 25, 2024

Description

Created assetpack download script for windows users using run-script-os

Objectives

  • Assetpack download script attempt 1

Testing Done

  • Test download script on windows computer (Brandon | Ayla)

JIRA Issue

@azaleacolburn azaleacolburn requested a review from a team as a code owner June 25, 2024 16:23
@azaleacolburn azaleacolburn requested review from HunterBarclay and a-crowell and removed request for a team June 25, 2024 16:23
@azaleacolburn azaleacolburn changed the title first attempt at windows assetpack download script windows assetpack download script Jun 25, 2024
@BrandonPacewic BrandonPacewic changed the title windows assetpack download script Windows assetpack download script Jun 25, 2024
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should maintain the 2 space formatting for all .json files.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there were still some files that were not up to date with the new formatting.

Download and unzip works on my Windows machine.

LGTM!

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my windows machine
👍

@HunterBarclay HunterBarclay merged commit 3f1aede into Autodesk:dev Jun 26, 2024
13 of 14 checks passed
@azaleacolburn azaleacolburn deleted the colbura/1715/assetpack-download-windows branch June 26, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants