Haverty/elevator bug #983
Merged
Haverty/elevator bug #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaHaverty
requested review from
HunterBarclay,
PepperLola,
a-crowell and
BrandonPacewic
LucaHaverty
added
bug
gameplay
a-crowell
reviewed
Jun 26, 2024
HunterBarclay
requested changes
Jun 26, 2024
There was a problem hiding this comment.
It seems to move pretty well. The major thing for me is how much the elevator pieces get tossed around. When moving the carriage, it shifts the second stage of the elevator a ton. Same with the arm movement. Is there something we can do to essentially add movement braking?
a-crowell
approved these changes
Jun 27, 2024
|
@LucaHaverty Could you resolve the merge conflicts, then we can merge this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed strange elevator behavior by adding velocity control. Elevator stages can now be controlled independently with much greater accuracy. Also reduces elevator stages moving each other and arms bouncing when reaching a position limit.