Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh APS Token #982

Merged
merged 16 commits into from
Jul 9, 2024
Merged

Refresh APS Token #982

merged 16 commits into from
Jul 9, 2024

Conversation

PepperLola
Copy link
Member

@PepperLola PepperLola commented Jun 19, 2024

Changes:

  • Refresh the APS auth data when requested after it's expired
  • Move code challenge generation and verifier to server

Testing:

  • Sign in with APS and make sure your name and pfp show up in the main HUD
  • Refresh token and see if name/pfp disappear and then reappear
  • Expire token (might have to click multiple times?) and see if same thing happens as refresh token

Important

The server has to be running when testing, which can be found in the website repo.

Important

  • Waiting on server update PR to merge

JIRA Issue

@PepperLola PepperLola self-assigned this Jun 19, 2024
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to tweak. Consult with this documentation for addressing errors.

fission/src/aps/APS.ts Outdated Show resolved Hide resolved
fission/src/aps/APS.ts Outdated Show resolved Hide resolved
fission/src/aps/APS.ts Outdated Show resolved Hide resolved
@PepperLola PepperLola marked this pull request as ready for review June 29, 2024 00:44
@PepperLola PepperLola requested a review from a team as a code owner June 29, 2024 00:44
@PepperLola PepperLola requested review from LucaHaverty and removed request for a team June 29, 2024 00:44
@PepperLola PepperLola mentioned this pull request Jul 1, 2024
6 tasks
@BrandonPacewic BrandonPacewic requested review from BrandonPacewic and removed request for LucaHaverty July 1, 2024 22:59
@HunterBarclay
Copy link
Member

image

I'm getting a number of errors. It's trying to use APS.auth but that is private.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to get the token to expire in such a way that resulted in a failure to login. This then followed a toast and this error:
image

Upon which the APS Login button seemed to be broken and would not let me login again.

Also there appears to be lots of error messages in the developer console while running this branch, things related to message ports closing before a expected response? Is this expected?

Edit - Steps to Reproduce:

  • Spam the expire token button.

Not sure that this issue would ever be reproducible in production, just want to make sure that this is not a symptom of a different problem.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous review comment, lets not let this get in the way anymore. It has been 3 weeks...

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to backtrack on previous review.

fission/src/Window.d.ts Outdated Show resolved Hide resolved
@HunterBarclay
Copy link
Member

@PepperLola I'm having issues with the code challenge endpoint. For some reason it's giving a 500 error

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Can't wait to see the further integration.

@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

@HunterBarclay HunterBarclay reopened this Jul 9, 2024
@HunterBarclay HunterBarclay merged commit 6020db0 into dev Jul 9, 2024
13 of 15 checks passed
@HunterBarclay HunterBarclay deleted the jwrigh/1699/aps-refresh-token branch July 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants