Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main HUD Improvements #893

Merged
merged 23 commits into from
Jul 26, 2023
Merged

Main HUD Improvements #893

merged 23 commits into from
Jul 26, 2023

Conversation

PepperLola
Copy link
Member

@PepperLola PepperLola commented Jul 19, 2023

Description

Improved the main HUD to fit with the Figma design, including a gradient background, the Autodesk logo, two separated buttons, and two item trays. The color manager sets the colors, so the default color scheme should be updated later. The hover effect in Figma is a lighter color than the background, but I don't think that's possible with the built-in color tint transition for Unity buttons. Luca is working on something that would make this possible, so I will update that once his is merged.

Screenshot 2023-07-20 at 4 54 06 PM

Objectives

  • Updated Main HUD design
  • Item hover effect
  • Open and close HUD (tween library breaks sometimes and causes the movement to not happen)
  • Update entries in practice mode
  • Update entries in match mode

Testing Done

  • Entered in modes available from main menu
  • Clicked buttons to make sure modals/panels appear
  • Change colors in theme manager
  • Open and close a lot (after restarting Unity so tween library works)

JIRA Issue

Copy link
Contributor

@Markytt Markytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to spawn in a robot using spawn assets or MultiBot, error messages will appear and the modal will appear without a dropdown.
Screenshot 2023-07-20 090430

Also if you try to click cancel on the model to make it disappear, an error message will appear saying that the modal failed to be closed.
Screenshot 2023-07-20 090500

@PepperLola PepperLola requested a review from Markytt July 20, 2023 16:59
@a-crowell a-crowell changed the base branch from master to dev July 20, 2023 17:03
Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. When you open a modal the open icon is still an X though. Same functionality, just the icon.

image

@PepperLola
Copy link
Member Author

I moved controls and settings out of config mode because those have global options and I think they should be accessible without having a robot loaded.

@a-crowell
Copy link
Collaborator

a-crowell commented Jul 20, 2023

I moved controls and settings out of config mode because those have global options and I think they should be accessible without having a robot loaded.

Thanks for catching the settings!
@KyroVibe I agree with taking out the controls if you've changed your mind.

Copy link
Collaborator

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

Couple things I noticed:

If you change the "interactive select" color, it does not update until you stop Unity and hit play again.

If you quit to the main menu, then save the theme editor in the main menu, then enter singleplayer again, the main HUD shows up like this before choosing a mode:

image

I also noticed that the button highlights are smaller than in figma. Additionally, the icons and text seem to be closer to the edge and to each other in figma. It looks like the figma version is shorter overall.

New Project (2)

Also, you might want to add a new color for the main hud buttons background because it is different than the new panel and modal bg color.

I have not found any issues with it's functionality. Just these small changes and it should be good to go!

Copy link
Collaborator

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I noticed a small x on the bottom of the screen, not sure if it's related to this pr or not but it doesn't seem to be on dev.

Screenshot 2023-07-21 at 11 36 51 AM copy

@LucaHaverty
Copy link
Collaborator

Looks good. I noticed a small x on the bottom of the screen, not sure if it's related to this pr or not but it doesn't seem to be on dev.

Screenshot 2023-07-21 at 11 36 51 AM copy

Pretty sure that's from the old toast system

Copy link
Collaborator

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any issues with how it works, nice job! I'm not a huge fan of how the button to collapse it is so far above the main hud though (especially in match mode). I think that users might not see it or not make the connection of what it is for. It is also hard to see against the background. Is there any way it could be part of the main hud or at least feel like they are related?

image

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much perfect. I would be a little concerned about players not know what to do if they were dropped into the sim without a robot or field and has the MainHUD collapsed but we can see about that with the beta. I would switch to use the new Tweening system because when I was testing the current one failed.

Copy link
Contributor

@Markytt Markytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem to be working well, the only bug I found was that in match mode, the controls shown sometimes still don't match the controls of the currently selected robot.

@PepperLola
Copy link
Member Author

Things seem to be working well, the only bug I found was that in match mode, the controls shown sometimes still don't match the controls of the currently selected robot.

Could you provide steps to reproduce this issue, and do you know if there's something specific that happens to trigger that or is it just random?

@PepperLola
Copy link
Member Author

I didn't find any issues with how it works, nice job! I'm not a huge fan of how the button to collapse it is so far above the main hud though (especially in match mode). I think that users might not see it or not make the connection of what it is for. It is also hard to see against the background. Is there any way it could be part of the main hud or at least feel like they are related?

image

I just recreated the way it looks in Figma. The skybox in that design was dark which made it easier to see, so maybe we could change the color of the icons later?

@PepperLola
Copy link
Member Author

Looks good. I noticed a small x on the bottom of the screen, not sure if it's related to this pr or not but it doesn't seem to be on dev.
Screenshot 2023-07-21 at 11 36 51 AM copy

This was from the old toast system and is gone now with the new one.

@PepperLola PepperLola requested a review from Markytt July 24, 2023 19:08
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean recreation of the new design!

Copy link
Collaborator

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fantastic work!

Copy link
Contributor

@Markytt Markytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is working great, I didn't find anymore issues or bugs.

@HunterBarclay HunterBarclay merged commit 570c721 into dev Jul 26, 2023
13 checks passed
@HunterBarclay HunterBarclay deleted the improvement/1575/main-hud branch July 26, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants