Exporter Typing with mypy [AARD-1765]

[BrandonPacewic]

"Fixed" 400+ type errors...

In addition to the type error fixes:

• Added a mypy typing workflow.
• Added .pyi typing files for our compiled proto files for lsp and intellisense.
• Fixed an issue with the GlobalManager where the internal class instance was the only thing ever being referenced.
  

  synthesis/exporter/SynthesisFusionAddin/src/GlobalManager.py

  Line 56 in 5807353

  return GlobalManager.instance

  • Essentially because of the return type of the __new__ method the class was simply not working how it was originally designed.
• Made note of several things todo in future refactors including:
  • OString needing more defined behaviour instead of revolving around the python 2 object type.
    

    synthesis/exporter/SynthesisFusionAddin/src/Types.py

    Line 281 in 5807353

    def ThumbnailPath(cls, fileName: str) -> object:

  • JointHierarchy.py's class structure being poorly defined.
    • I resolved the apparent errors that mypy pointed out but the whole structure needs to be rewritten, particularly when it comes to how the various type of nodes are currently being used, many of which I'm sure can just be removed.
    • I also fixed some typing errors that seemingly looked like syntax errors related to the Fusion API and other functions within the module.
• Provided default_factorys for ExporterOptions' list default fields.
• Replaced default values for ExporterOptions fields of None where appropriate.
• Noted various instances of unused code that, given the observed type errors, would never run even if we wanted to use it.
  • This code should be removed in the future as a part of separate refactors.
  • See included Transition: AARD-1765 comment tags for references to individual code sections.
• Fixed an issue within construct_info that would cause AttributeErrors to be thrown during exporting making debugging painful.

  synthesis/exporter/SynthesisFusionAddin/src/Parser/SynthesisParser/Utilities.py

  Lines 54 to 59 in 5807353

  	try:
  	# attempt to get entity token
  	proto_obj.info.GUID = fus_object.entityToken
  	except AttributeError:
  	# fails and gets new uuid
  	proto_obj.info.GUID = str(uuid.uuid4())

JIRA Issue

[azaleacolburn]

Amazing Work!

[autodesk-chorus]

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

[PepperLola]

Good Looking 🌹