Transform Gizmo Refactor #1085
Open
Transform Gizmo Refactor #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to implement elsewhere in the code and also delete old implementation
Dhruv-0-Arora
requested review from
a-crowell and
LucaHaverty
and removed request for
a team
LucaHaverty
requested changes
Aug 7, 2024
🫠 |
There was a problem hiding this comment.
Looks like this has some pretty extensive merge conflicts from #1068.
a-crowell
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
I'm still not sure that this 100% addresses the concerns that @HunterBarclay had.
Yep I just added all the refactoring changes that I could remember |
WIP: Migrating scheme selection to a component atm.
WIP: Making a new panel combining input scheme selection and assembly transformation into one.
This feature also adds additional upgrades and refactoring to how pausing is handled. It adds the side-effect of when an assembly fails to be spawned in, the simulation will remain paused for approx. 500 ms. Also includes global UI controls that can be accessed from anywhere.
Also added in a couple cleanups here and there.
Also finally moved the ground up as well.
Co-authored-by: PepperLola <[email protected]>
Co-authored-by: PepperLola <[email protected]>
Also included some snapping controls.
HunterBarclay
approved these changes
Oct 11, 2024
WIP!: Currently not working for removing input schemes from deleted robots.
The TransformGizmoContro now contains callbacks for when it "receives" the signal to cancel or accept it's position via the escape and enter keys respectively.
HunterBarclay
requested review from
PepperLola,
azaleacolburn and
HunterBarclay
and removed request for
a team and
HunterBarclay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the Transform Gizmos to be a
SceneObject.Changes
GizmoSceneObjectfile. This includes mapping transformations of the mesh to the mirabuf.SceneRendererHunter's Additions
GlobalUIControlsandGlobalUIComponentto provide access to context controls outside of react components. Probably not the best practice, but make sense considering these context controls will be relevant for the entire lifetime of the application, not just a single component/menu.GizmoSceneObjectare via theTransformGizmoControlcomponent. This allows were easy lifetime controls when using the gizmos.(0, 0 + half of bounding box height, 0)anchored around the center of their bounding box.JIRA Issue