Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-1521 modify AE section order #3975

Merged
merged 3 commits into from
Oct 28, 2024
Merged

EMSUSD-1521 modify AE section order #3975

merged 3 commits into from
Oct 28, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

  • Accumulate all schemas and their attributes before creating any UI for them.
  • Re-ordered schemas according to the design.
  • Renamed Xformable to Transforms.
  • Made all sections be collapsed by default except the prim type section, Light and Light type
  • Removed the "Applied Schemas" section.
  • Add a unit test and fix some tests that assumed sections would be expanded.

@pierrebai-adsk pierrebai-adsk self-assigned this Oct 24, 2024
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1521/lights-attrs-in-AE branch from aa597e1 to db8638d Compare October 24, 2024 16:07
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1521/lights-attrs-in-AE branch from db8638d to 8b2eaa4 Compare October 24, 2024 17:29
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1521/lights-attrs-in-AE branch from 8b2eaa4 to 0892409 Compare October 24, 2024 18:30
@pierrebai-adsk pierrebai-adsk self-assigned this Oct 24, 2024
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1521/lights-attrs-in-AE branch from 0892409 to 96fd9a2 Compare October 24, 2024 20:03
@pierrebai-adsk
EMSUSD-1521 modify AE section order
e1630a2 
- Accumulate all schemas and their attributes before creating any UI for them.
- Re-ordered schemas according to the design.
- Renamed Xformable to Transforms.
- Made all sections be collapsed by default except the prim type section, Light and Light type
- Removed the "Applied Schemas" section.
- Add a unit test and fix some tests that assumed sections would be
  expanded.
- Make all sections (except materials, which has a special logic) be
  re-orderable in the future.
- Update the documentation to reflect the changes.
@pierrebai-adsk pierrebai-adsk removed their assignment Oct 24, 2024
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1521/lights-attrs-in-AE branch from 96fd9a2 to e1630a2 Compare October 24, 2024 20:23
@pierrebai-adsk pierrebai-adsk self-assigned this Oct 24, 2024
seando-adsk
seando-adsk previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Just a couple of minor typos. If you want to add those in, just mark the PR as ready-to-merge (no need to re-run preflight since I see that it passed already).

lib/mayaUsd/resources/ae/usdschemabase/Attribute-Editor-Template-Doc.md Outdated Show resolved Hide resolved
lib/mayaUsd/resources/ae/usdschemabase/ae_template.py Outdated Show resolved Hide resolved
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 25, 2024
@seando-adsk seando-adsk added the adsk Related to Autodesk plugin label Oct 28, 2024
@seando-adsk seando-adsk merged commit 607da29 into dev Oct 28, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1521/lights-attrs-in-AE branch October 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seando-adsk seando-adsk seando-adsk approved these changes

Assignees

@pierrebai-adsk pierrebai-adsk

Labels
adsk Related to Autodesk plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierrebai-adsk @seando-adsk