-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C-5365] Upgrade to react-native 76 #10327
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work dude
@@ -40,7 +40,7 @@ | |||
"redux-devtools": "redux-devtools --port=8000 --open", | |||
"start:e2e": "RN_E2E=true react-native start", | |||
"start:storybook": "RN_STORYBOOK=true react-native start", | |||
"start": "react-native start --experimental-debugger", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
minSdkVersion = 23 | ||
compileSdkVersion = 34 | ||
buildToolsVersion = "35.0.0" | ||
minSdkVersion = 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what percentage of devices we are losing support for with this new minimum? Also may be good to double check there are no migrations needed on the android/ios side, I think we've run into that before when bumping the min versions
e064d10
to
e278c95
Compare
Description
Upgrades react-native from 75x to 76. This will be the final upgrade for a while. Note we are not turning the new architecture on because there are various libraries that are still not compatible. The main blocker is react-native-track-player.