Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-5365] Upgrade to react-native 76 #10327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dylanjeffers
Copy link
Contributor

Description

Upgrades react-native from 75x to 76. This will be the final upgrade for a while. Note we are not turning the new architecture on because there are various libraries that are still not compatible. The main blocker is react-native-track-player.

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: e278c95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers dylanjeffers requested review from a team and amendelsohn and removed request for a team November 4, 2024 14:48
Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work dude

@@ -40,7 +40,7 @@
"redux-devtools": "redux-devtools --port=8000 --open",
"start:e2e": "RN_E2E=true react-native start",
"start:storybook": "RN_STORYBOOK=true react-native start",
"start": "react-native start --experimental-debugger",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

minSdkVersion = 23
compileSdkVersion = 34
buildToolsVersion = "35.0.0"
minSdkVersion = 24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what percentage of devices we are losing support for with this new minimum? Also may be good to double check there are no migrations needed on the android/ios side, I think we've run into that before when bumping the min versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants