Remove staked contracts check #1400
Conversation
|
Visit the preview URL for this PR (updated for commit a0ae524): https://astar-apps--pr1400-fix-stake-validation-0ihsi0zb.web.app (expires Fri, 25 Oct 2024 12:49:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
| } else if ( | ||
| constants.value && | ||
| (ledger.value?.contractStakeCount ?? 0) >= constants.value.maxNumberOfStakedContracts | ||
| ) { | ||
| return [ | ||
| false, | ||
| t('stakingV3.dappStaking.TooManyStakedContracts'), | ||
| docsUrl.dappStakingStaked16Dapps, | ||
| ]; |
There was a problem hiding this comment.
Just informative - the check isn't completely wrong, just incomplete.
You should also check that the dapp on which the user is trying to stake doesn't have an existing DB entry for the user.
If it does, the call will work, because existing entry is being modified, which won't increase number of staked contracts.
If a new contract is being staked on, one for which the staker doesn't have an entry in the DB, then the call will fail.
There was a problem hiding this comment.
Thanks, I will update the code
Pull Request Summary
Removed number of staked contracts check from
canStakemethod since we are callingcleanupExpiredEntriesbefore staking, if needed.Check list