Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Shibuya governance params #1351

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Sep 5, 2024

Pull Request Summary

  • reduce collective agreement requirement to half from two thirds to allow extending the council more easily
  • modify duration of enactment/voting/launch periods & collective motion duration to make them easier to test (and detect unwanted activities)

@Dinonard Dinonard added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Sep 5, 2024
@Dinonard
Copy link
Member Author

Dinonard commented Sep 5, 2024

I can reduce it even further perhaps, to 1/3 or 1/4. Let me know what you think.

Copy link

github-actions bot commented Sep 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/dapp-staking/src/test 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/ethereum-checked/src 74% 0%
precompiles/assets-erc20/src 78% 0%
precompiles/unified-accounts/src 100% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/collator-selection/src 92% 0%
pallets/inflation/src 93% 0%
pallets/dapp-staking/src/test 0% 0%
primitives/src/xcm 65% 0%
pallets/xc-asset-config/src 50% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/unified-accounts/src 86% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/xcm/src 71% 0%
pallets/static-price-provider/src 85% 0%
pallets/dapp-staking/src 83% 0%
primitives/src 57% 0%
pallets/collective-proxy/src 86% 0%
pallets/price-aggregator/src 82% 0%
precompiles/dapp-staking/src 90% 0%
Summary 79% (3634 / 4606) 0% (0 / 0)

Minimum allowed line rate is 50%

@ermalkaleci ermalkaleci merged commit f1475d0 into master Sep 9, 2024
10 checks passed
@ermalkaleci ermalkaleci deleted the feat/adjust-shibuya-governance-params branch September 9, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants