Skip to content

Commit

Permalink
Siren 4.0.0 (#250)
Browse files Browse the repository at this point in the history
* Scoping changes to most utility classes

* Updated docs

* Continued code clean up and file renaming

* Metadata cleanup

* Updated docs

* Updated Siren.podspec to 4.0.0

* Massive overhaul of the localization logic

* Fixed tests

* Updated docs

* Minor cleanup

* Added new Configuration type but have not hooked it up

* Non-working commit for Configuration

* Continued configuration by thinning down Siren's main interface

* Removed singleton and improved window presenting logic

* Removed dead code. Confined utility methods to proper locations

* Updated some documentation

* Rebuilt version checking and alert presentation logic, however skip alert presentation logic is broken

* Fixed skip version logic

* Added default settings

* Removed delegates and added completion handler

* Changed initialization scheme

* Minor changes to initialization

* Fixed tests and error logic

* Minor changes to sample project

* Renamed all managers

* Improved Errors

* Continued cleanup

* Mor cleanup

* Continued cleanup

* Removed Log struct as it is no longer needed. Removed unused helpers. Merged remaining helpers into mainline Siren.swift file

* Began adding more documentation

* Renamed alertManager to presentationManager

* Removed redundant comments

* Changed alphabetical ordering

* Added some more built in rules

* minor improvemeent to VersionCheckFrequency

* Code cleanup

* Added some missing errors

* More robust error handling

* Added more rules

* Changed start to wail

* Added deviceLanguageLocalization

* Added documentation to BundleExtension

* Added DateExtension documentation

* Added UIAlertController extension documentation

* Added UserDefaultsExtension documentation

* Added APIManager documentation

* Added PresentationManager documentation and began adding RulesManager documentation

* Added AlertAction documentation

* Added Results.swift documentation

* Added Rules.swift documentation

* Added documentation to VersionParser and SirenViewController

* Some metadata cleanup

* Lots more documentation

* Moved networking code in APIManagr.swift

* Moved lots of logic out of siren and into PresentationManager and Localization

* More abstraction

* Cleaned up alert presentation

* More cleanup

* minor changres

* App now has less properties, improved uni-directional flow, and tests that account for that

* Continued code modification

* More documentation changes

* More scope changes

* More scope changes

* More documentation

* Fixed app store version null bug

* More changes

* Reorganized code in presentationmanager

* Reorganized code in presentationmanager

* Improved cache handling

* Added a lot more documentation and removed some unnecessary optionality

* Continued adding documentation

* Fixed bug with layering of alert. Tons more documentation

* Finished documenting all functions and properties

* Updated jazzy docs

* Added missing documentation

* Removed superfluous files

* Fixed bugs around prompt frequency. Updated code and documentation around prompt frequency

* Reached 100% of private function and beyond documentation

* Fixed bug arond presenting localized strings vs custom strings

* Added lots of examples to AppDelegate. Updated README. Removed attributed string settings since they never worked

* Documentation updated. Added tons of examples to AppDelegate.swift with comments

* Updated README

* Updated README.md

* Updated README.md

* Updated README.md

* Removed random fragment in readme

* Updated README

* More README updates

* More README updates

* Updated README

* More metadata updates

* Update metadata

* Regenerated jazzy docs
  • Loading branch information
ArtSabintsev authored Dec 27, 2018
1 parent 168cc43 commit dbfe200
Show file tree
Hide file tree
Showing 147 changed files with 28,871 additions and 3,424 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- **What is your app's Bundle ID?**:
- **When was the latest version of your app published to the App Store?**:
- **Is your app published in the US App Store? If not, what App Store is it published in?**:
- **Does Siren work if you plugin your app's BundleID (and CountryCode, if necessary) into the Example App?**:
- **Does Siren work if you plugin your app's `BundleID` (and `countryCode`, if necessary) into the Example app?**:

---

Expand Down
1 change: 0 additions & 1 deletion .ruby-version

This file was deleted.

6 changes: 2 additions & 4 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@ included:

disabled_rules:
- cyclomatic_complexity
- line_length
- nesting
- unused_optional_binding
- variable_name

# Specialized Rules
file_length:
- 1000

line_length:
- 200
- 500
83 changes: 0 additions & 83 deletions CONTRIBUTORS.md

This file was deleted.

Loading

0 comments on commit dbfe200

Please sign in to comment.