mavutil: Raise ValueError instead of exiting #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of this library may want to handle these values being wrong. While it is possible to handle sys.exit, it is more conventional to raise a ValueError on incorrect data passed as an argument.
peterbarker
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Tested MAVProxy's error output and it doesn't make much difference as MAVProxy caches any exception and handles it:
pbarker@fx:~/rc/pymavlink((HEAD detached at Newbytee/raise-value-error-instead-of-exit))$ mavproxy.py --master udp:bob
Connect udp:bob source_system=255
Failed to connect to udp:bob : UDP ports must be specified as host:port
pbarker@fx:~/rc/pymavlink((HEAD detached at Newbytee/raise-value-error-instead-of-exit))$
... it actually fixes a bug in MAVProxy if you screw up:
STABILIZE> Adding link udp:bob
Connect udp:bob source_system=255
UDP ports must be specified as host:port
STABILIZE>
STABILIZE>
STABILIZE> link add udp:bob
STABILIZE>
STABILIZE>
STABILIZE>
STABILIZE> link add udp:bob
STABILIZE> status
STABILIZE> status
STABILIZE>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of this library may want to handle these values being wrong. While it is possible to handle sys.exit, it is more conventional to raise a ValueError on incorrect data passed as an argument.