Move SPEED_TYPE enumeration to common.xml, use it in DO_CHANGE_SPEED #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SPEED_TYPE enum for MAV_CMD_DO_CHANGE_SPEED * Update message_definitions/v1.0/common.xml * Update message_definitions/v1.0/common.xml * Update message_definitions/v1.0/common.xml
|
Re description change - which one? "Change speed and/or throttle set points" isn't a change. |
The statement that the speed reverts on mode change - I'm not 100% sure that applies on all ArduPilot vehicles. We may retain the specified speed when going between Plane LOITER and Plane GUIDED modes, for example. I haven't tested - but if the author of the change can say they have tested such things we could make that change :-) |
Ah, the text has always said "setpoint" so it probably should revert on mode change. |
tridge
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from upstream
I've reverted the description change as another patch; I don't know whether we actually honour that description in ArduPilot. We may persist this across mode changes, I haven't checked.