Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS: update rosdep command #6359

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

srmainwaring
Copy link
Contributor

Add -y -r flags to continue on error and accept all changes.

Add `-y -r` flags to continue on error and accept all changes.
@Ryanf55
Copy link
Contributor

Ryanf55 commented Oct 30, 2024

Which package do we need the -r flag for?

@srmainwaring
Copy link
Contributor Author

Gazebo harmonic packages are not found using rosdep on jammy. Could use skip keys or the alternative rosdep sources for non-standard distros as is done in the ardupilot_ros CI workflow definition.

rosdep-missing

@Ryanf55
Copy link
Contributor

Ryanf55 commented Oct 30, 2024

Yea, perhaps it's time we start recommending this workflow to our users. It works well.
https://github.com/ArduPilot/ardupilot_ros/blob/940efb9a41d80eb6d4ae5a0f66cdab412f2a1e70/.github/workflows/colcon.yml#L44

@Hwurzburg
Copy link
Contributor

going to merge as is, since it appears okay...further changes can be in a future PR

@Hwurzburg Hwurzburg merged commit cd1512a into ArduPilot:master Oct 31, 2024
5 checks passed
@srmainwaring srmainwaring deleted the patch-3 branch October 31, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants