Bootloader: Add Reading of Git SHA to bootloader #28492
Open
+67
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshanne
commented
Oct 29, 2024
Tools/AP_Bootloader/bl_protocol.cpp
Outdated
| @@ -128,6 +128,7 @@ | |||
| #define PROTO_DEVICE_FW_SIZE 4 // size of flashable area | |||
| #define PROTO_DEVICE_VEC_AREA 5 // contents of reserved vectors 7-10 | |||
| #define PROTO_DEVICE_EXTF_SIZE 6 // size of available external flash | |||
| #define PROTO_DEVICE_BL_GIT_HASH 7 // git hash of bootloader build | |||
| // all except PROTO_DEVICE_VEC_AREA and PROTO_DEVICE_BOARD_REV should be done | |||
| #define CHECK_GET_DEVICE_FINISHED(x) ((x & (0xB)) == 0xB) | |||
There was a problem hiding this comment.
I'm unsure if this line would need to be updated to 0x4B?
|
This is helpful for users building their own bootloaders, and allowing the user to identify what commit the build was built at. Feedback welcome. |
joshanne
force-pushed
the
pr/git-hash-in-bootloader
branch
from
da23530
to
29788c9
Compare
joshanne
commented
Oct 29, 2024
Tools/AP_Bootloader/bl_protocol.cpp
Outdated
| @@ -128,6 +128,7 @@ | |||
| #define PROTO_DEVICE_FW_SIZE 4 // size of flashable area | |||
| #define PROTO_DEVICE_VEC_AREA 5 // contents of reserved vectors 7-10 | |||
| #define PROTO_DEVICE_EXTF_SIZE 6 // size of available external flash | |||
| #define PROTO_DEVICE_BL_GIT_HASH 7 // git hash of bootloader build | |||
There was a problem hiding this comment.
I've also got changes that add reading off the Application Git SHA if AP_CHECK_FIRMWARE_ENABLED is enabled in the bootloader (and application).
We certainly would find these handy, just a question of if this is desirable in the bootloader.
khancyr
reviewed
Oct 30, 2024
joshanne
force-pushed
the
pr/git-hash-in-bootloader
branch
from
29788c9
to
ddfcf85
Compare
Allows for reading of the git sha from the bootloader to ascertain the sha the bootloader is built at
joshanne
force-pushed
the
pr/git-hash-in-bootloader
branch
from
ddfcf85
to
8b6bb5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the bootloader build to be identified with
uploader.py