Improve support for the Allystar Receiver/Heading receiver #28432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datagnss
commented
Oct 19, 2024
datagnss
commented
- add support allystar Heading sentence $PALYSBLS
- add support for forcing the NMEA output rate to 5Hz
- add support allystar Heading sentence $PALYSBLS - add support for forcing the NMEA output rate to 5Hz
peterbarker
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Please outline what testing this has had.
Have you tested compiling this with AllyStar compiled out?
Please tidy the commit list; should be a single commit something along the lines of AP_GPS: add support for AllyStar NMEA variant
Please add to build_options.py and extract_features.py
| AllyStar Moving Baseline extensions | ||
| */ | ||
| #if AP_GPS_NMEA_ALLYSTAR_ENABLED | ||
| if (strcmp(_term, "PALYSBLS") == 0) { |
There was a problem hiding this comment.
OK, thanks.
we will finish some test report , then reopen a new pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.