-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: scripts: Update MAVLink parsing for wiki inclusion #27226
base: master
Are you sure you want to change the base?
Conversation
@amilcarlucas where/when are you expecting/wanting yours to run? As far as I'm aware the parameters repository already generates all the I'm not sure how much sense it would make to combine efforts on a PR in that repo, given your feature is an additional endpoint for the parameters, whereas mine is a new script to run and store the outputs of, but if you're also wanting to include the MAVLink message support in your rsync transfers then I suppose that ties them together somewhat? |
Nevermind, I jumped to conclusions. |
Did some more digging and found that adding a version selection dropdown makes more sense to handle as a patch during generation in the specific applications where it's relevant. Since both of the remaining "planned" components of this PR can be handled in separate repositories, I think this is ready for review / can be merged in 🙂 |
Not really sure who should review this PR, but @Hwurzburg might have some ideas or preferences around the formatting of the generated files 🤷♂️ |
Was all the formatting in the example sub file generated by this script? |
Yeah - the I generated it from the
(noting once again that the script requires Python 3.11 to run) |
I've tagged @peterbarker and @IamPete1 to review if the groupings and generated data is correct....with PeterB's help I could add per vehicle pages into the Dev sites wiki under a MAVLink commands topic.... |
ArduPilot Wiki uses reStructuredText (rst) source files, so supporting rst output is essential for this script to generate wiki files.
199f475
to
adf87f3
Compare
I've just rebased over master, and generated some more rst files for different vehicle types, to make that checking a bit more straightforward: MultiVehicle_master_MAVLink_Messages.zip
Nice! 😃 I'd note that because the MAVLink protocol updates, and I'm currently including the "unsupported messages" in the output generation, the outputs for each version should ideally be re-generated each time with the latest script version, and the most recent pymavlink release, rather than tying the script to the vehicle branch and only generating once per version. That said, that's not a critical requirement, and generating once per version could be ok if we either accept that newer messages won't show up, or just don't generate the unsupported messages - I just like the idea of being able to search for a message and finding out clearly if it is definitely unsupported 🤷♂️ |
having to manually update the page generation once in a while is fine for now, IMO....a PR to generate the page would be good, then I can add it to the Dev wiki.....very few users, and only devs, will be using it but it will certainly help them, even if occasionally out of date... |
Initial files are now available for the ≥ 4.0 tags in the parameters repository :-) They'll still need some re-jigging of the anchors (and insertion of a version selector dropdown) before they can be included in the wiki, but that'll be very similar to the existing process for parameter files, that happens during wiki generation. |
sorry its taken me so long to get back to this, but I wanted to add wiki files for Plane,Copter,Rover messages as of current master....the params repo does not even have files for 4.5...could you generate these three and I will ad to dev wiki...thanks |
I get it - unfortunately the list of interesting/useful things to do seems to grow much faster than the available time to do things 😅
It's been a while since I did those initial generations, so I'll need to figure out the relevant setup/process again. I'm hoping it's mostly covered by the Action I made in the parameters repo, although from memory that's reliant on this PR being merged, so I might need to make some custom branches to do the manual generations for now. I'll try to sort that out this week :-)
To confirm, did you want files for just the 4.5 release, or current master as well? |
4.6 is about to drop...so master only will be fine |
ArduPilot Wiki uses reStructuredText (rst) source files, so supporting rst output is essential for this script to generate wiki files. Ideally this can be run automatically for every vehicle type and version, like the existing parameter lists.
Add rst support
Example file for ArduSub 4.1, with all options included:
ArduSub_Sub-4.1_MAVLink_Messages.rst.zip
EDIT: Some additional example files from the
master
branch, for different vehicle types (all message options included):MultiVehicle_master_MAVLink_Messages.zip
EDIT2: Example files for released firmware versions have been added here
EDIT3: Wiki inclusion and future planning notes moved to ArduPilot/ardupilot_wiki#6065