Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print received Remote ID messages on serial console for both MAVLink and DroneCAN #100

Merged
merged 1 commit into from
Oct 16, 2023
Merged

print received Remote ID messages on serial console for both MAVLink and DroneCAN #100

merged 1 commit into from
Oct 16, 2023

Conversation

BluemarkInnovations
Copy link
Contributor

  • existing code did only print a message on the serial console if a Remote ID message was received via DroneCAN.
  • this PR prints those messages for MAVLink too. And includes also the interface where the packet was received.

tridge
tridge requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it deliberately doesn't print for MAVLink as when testing in SITL Serial is running MAVLink, and the Serial.printf() corrupts the MAVLink stream, losing messages (and making a mess of the console with noise)
We could have an option bit to enable printfs, or we could make it do Serial.printf() only if Serial mavlink instance has not received any HEARTBEAT messages

@BluemarkInnovations
Copy link
Contributor Author

I have chosen to use the options variable. Also did a rebase and squash of all commits.

@BluemarkInnovations
Copy link
Contributor Author

Seems to be solved, see comment of April 3rd

@tridge
Copy link
Contributor

tridge commented Oct 16, 2023

rebased and fixed conflicts

@tridge tridge merged commit 9db0c27 into ArduPilot:master Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BluemarkInnovations @tridge