Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/6.x.x/6.14.x/6.14.3 rc2 #546

Merged
merged 15 commits into from
Apr 28, 2024
Merged

Conversation

al-af
Copy link
Contributor

@al-af al-af commented Apr 28, 2024

  • Add privacy manifest
  • Update Android to 6.14.0
  • Update iOS to 6.14.3

@al-af al-af merged commit 2bfc042 into master Apr 28, 2024
3 of 4 checks passed
@alhassanreem alhassanreem mentioned this pull request Apr 29, 2024
package="com.appsflyerexample">

<uses-permission android:name="android.permission.INTERNET" />

<application
tools:replace="android:allowBackup"
Copy link

@swrobel swrobel May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? This seems to cause a breaking change @al-af:

> Task :app:processInternalReleaseMainManifest FAILED
/Users/swrobel/Code/myapp/android/app/src/main/AndroidManifest.xml:6:161-188 Error:
	Attribute application@allowBackup value=(false) from AndroidManifest.xml:6:161-188
	is also present at [com.appsflyer:af-android-sdk:6.14.0] AndroidManifest.xml:32:9-35 value=(true).
	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:6:2-33:16 to override.

EDIT: Maybe this is actually coming from the appsflyer Android lib due to the bump to 6.14.0, but this is still a conflict with the default config for React Native apps

Copy link

@CTOverton CTOverton May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swrobel @al-af any update on when this will be fixed? We want to upgrade to use the latest appsflyer sdk that includes the required privacy manifest for iOS but this is a breaking change that prevents android from building.

Similar error I received after upgrading:

Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:26:9-36
	is also present at [com.appsflyer:af-android-sdk:6.14.0] AndroidManifest.xml:32:9-35 value=(true).
	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:7:5-117 to override.

Issue for tracking: #551

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@al-af Could you please let me know when this will be fixed? If we change the android:allowBackup="true" in AndroidManifest.xml then it's making an issue with our app features like app auto upgradation from the Play Store.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants