Merge pull request #12 from AppsFlyerSDK/DELIVERY-62168/semverBugFix

Delivery 62168/semver bug fix

__tests__/utils/utils.test.js

@@ -0,0 +1,19 @@
+import {isVersionGreaterThanOrEqualTo} from "../../src/platforms/utils/utils.js"
+
+const MINIMUM_OS_VERSION_SUPPORTED = "4.0.0"
+let falseDataSet = ["1.0.0", "1.0", "2.0", "3.99", "3.9", "0", "0.0", null, undefined, "", 0,  2]
+let trueDataSet = ["4", "4.0.0", "4.1", "4.0.1", "5", "5.0", "5.0.0", 4, 4.1, 5, 5.5, 44]
+
+
+it.each(falseDataSet)("false response for isVersionGreaterThanOrEqualTo", async (version) => {
+    console.log(version)
+    expect(isVersionGreaterThanOrEqualTo(version, MINIMUM_OS_VERSION_SUPPORTED)).toEqual(false);
+})
+
+it.each(trueDataSet)("true response for isVersionGreaterThanOrEqualTo", async (version) => {
+    console.log(version)
+    expect(isVersionGreaterThanOrEqualTo(version, MINIMUM_OS_VERSION_SUPPORTED)).toEqual(true);
+})
+
+
+

package.json

@@ -1,6 +1,6 @@
 {
   "name": "appsflyer-html5-ctv-sdk",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "AppsFlyer SDK for TV application",
   "type": "module",
   "directories": {
@@ -22,15 +22,13 @@
   "author": "appsflyer",
   "license": "ISC",
   "devDependencies": {
-    "@babel/preset-env": "~7.18.9",
+    "@babel/preset-env": "7.23.2",
     "babel-jest": "~28.1.3",
     "babel-loader": "~8.2.5",
-    "babel-preset-es2015": "~6.24.1",
     "eslint": "~8.20.0",
     "eslint-config-google": "~0.14.0",
     "jest": "~28.1.3",
     "jest-fetch-mock": "~3.0.3",
-    "semver": "~7.3.8",
     "webpack": "~5.84.1",
     "webpack-cli": "~4.10.0"
   }

src/AppsFlyerSDK.js

@@ -4,8 +4,9 @@ import LG from './platforms/lg.js';
 import Vizio from './platforms/vizio.js';
 import Vidaa from './platforms/vidaa.js';
 import {INVALID_SDK, DEVICE_OS_NOT_SUPPORT, NO_PLATFORM_FOUND} from './core/utils/constants.js';
+import {MINIMUM_OS_VERSION_SUPPORTED} from './platforms/utils/constants.js';
+import {isVersionGreaterThanOrEqualTo} from './platforms/utils/utils.js';
 import {Platform} from './platforms/utils/types.js';
-import semver from 'semver';
 
 const PLATFORM_MAPPING = [Samsung, LG, Vizio, Vidaa]
 
@@ -81,9 +82,9 @@ class AppsFlyerSDK {
   setCustomerUserId(userId) {
     return this.isSDKValid() ? this.appsflyerInstance.setCustomerUserId(userId) : new Error(INVALID_SDK);
   }
-
+  
   async validateOSVersion(os, osVersion){
-    if((os == Platform.Tizen || os == Platform.Webos) && semver.gte(semver.coerce(osVersion), '4.0.0')){
+    if((os == Platform.Tizen || os == Platform.Webos) && isVersionGreaterThanOrEqualTo(osVersion, MINIMUM_OS_VERSION_SUPPORTED)){
       return true
     }else{
       let raw = navigator.userAgent.match(/Chrom(e|ium)\/([0-9]+)\./);

src/platforms/utils/constants.js

@@ -1,3 +1,3 @@
 export const DEFAULT_DEVICE_ID = "00000000-0000-0000-0000-000000000000";
-
-export const DEFAULT_APP_VERSION = '0.0.0';
+export const DEFAULT_APP_VERSION = '0.0.0';
+export const MINIMUM_OS_VERSION_SUPPORTED= '4.0.0'

src/platforms/utils/utils.js

@@ -0,0 +1,33 @@
+export const isVersionGreaterThanOrEqualTo = (versionA, versionB) => {
+    const isValidVersion = (version) => {
+        return version !== null && version !== undefined && version !== "";
+    };
+
+    if (!isValidVersion(versionA)) {
+        return false;
+    }
+
+    const normalizeVersion = (v) => v.split('.').map(part => parseInt(part, 10)); // Normalize version string
+
+    const compareVersions = (partsA, partsB) => {
+        const maxLength = Math.max(partsA.length, partsB.length);
+
+        for (let i = 0; i < maxLength; i++) {
+            const partA = partsA[i] || 0; // Use 0 if no more parts in version
+            const partB = partsB[i] || 0; // Use 0 if no more parts in version
+
+            if (partA > partB) {
+                return true;
+            } else if (partA < partB) {
+                return false;
+            }
+        }
+
+        return true; // Versions are equal
+    };
+
+    const partsA = normalizeVersion(typeof versionA === 'number' ? versionA.toString() : versionA);
+    const partsB = normalizeVersion(versionB);
+
+    return compareVersions(partsA, partsB);
+};