Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lux #3210

Closed
wants to merge 1 commit into from
Closed

Update lux #3210

wants to merge 1 commit into from

Conversation

kfjahnke
Copy link
Contributor

The latest version has a modified AppRun which may help with the creation of a default snapshot during the test of the Appimage

The latest version has a modified AppRun which may help with the creation of a default snapshot during the test of the Appimage
@probonopd
Copy link
Member

Related tp #3209.

@probonopd probonopd closed this Jul 31, 2023
@kfjahnke
Copy link
Contributor Author

Let me explain: I checked https://appimage.github.io/lux/ and noticed that it does not offer a download button, and it doesn't link to my work at all. So I rewrote the metadata.xml and put in as much info as I could hoping that the scan would produce some link to my project from, e.g., the URL I include.

While I was at it I thought I could change the AppRun to invoke lux so that your test would get a valid default snapshot.
Initially I got the pull request wrong, trying to go via patch-2 - and I couldn't trigger the test. Then I noticed, at the bottom of https://appimage.github.io/lux/, the link to update it: https://github.com/AppImage/appimage.github.io/blob/master/data/lux. That link resulted in the patch-3 branch and triggered the test, but now even the main test did not come out passed and the snapshot test failed as well.

So I'm a bit at a loss what else to do. Can you give a helpful hint?

@kfjahnke kfjahnke deleted the patch-3 branch August 3, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants