Create lux

[kfjahnke]

second attempt to add lux to the catalog, trying slightly different syntax for the screenshot

[probonopd]

This is the screenshot that was created:

Is this correct?

[probonopd]

@kfjahnke have you ever seen the message above? Is that something your program does? Potentially a bug when it is being invoked without any parameters?

We are making these screenshots to see what the end user experience "out of the box" would be. And as a user, seeing this message, I'd assume something is broken.

[probonopd]

Still getting

but maybe it's ok to allow this for now if we assume that most systems will have kdialog/zenity/tkinter available.

On my local FreeBSD machine it works. If kdialog or zenity is there, it uses it; if not, it uses Python with tkinter.

[probonopd]

Another minor nitpick:

The AppDir does not work when not inside an AppImage.

% ~/Downloads/lux-master-x86_64.AppImage --appimage-extract
% ./squashfs-root/AppRun                                
./squashfs-root/AppRun: Zeile 12: /usr/bin/lux: No such file or directory

This is because $APPDIR is not set when the AppDir is not running from inside an AppImage. So we need to set a variable in the AppRun file. E.g., like this:

#! /bin/sh

# AppRun script for lux AppImage

# lux needs to know where to find its standard font.
# The font's location is passed to the binary via the
# -w parameter, because it can only be known once the
# invocation has set up the temporary file system
# containing the binary and set the HERE environment
# variable accordingly. Other parameters follow ($@).

HERE="$(dirname "$(readlink -f "${0}")")"
"${HERE}/usr/bin/lux" -w "${HERE}/usr/share/lux/fonts/NotoSans-Regular.ttf" "$@"

[kfjahnke]

Still getting
...
but maybe it's ok to allow this for now if we assume that most systems will have kdialog/zenity/tkinter available.
On my local FreeBSD machine it works. If kdialog or zenity is there, it uses it; if not, it uses Python with tkinter.

I thought the requirement was just that the AppImage runs on the oldest still-supported ubuntu LTS, namely 18.04. I set up a VM with ubuntu 18.04 and ran the AppImage there and it worked, so I assumed it would work be fine.

FreeBSD? I thought AppImage was only for Linux! There actually is a FreeBSD port of lux in the graphics section.

$APPDIR is not set when the AppDir is not running from inside an AppImage. So we need to set a variable in the AppRun file. E.g., like this: ...

Do I understand that correctly: this change is to allow the unbundled AppImage to be run in the test environment? Fine with me. I'll change the AppRun. I was relying on APPDIR always being set, and I never tried to run the unbundled AppDir! I'll post again when I have the new AppImage online.

[probonopd]

I thought the requirement was just that the AppImage runs on the oldest still-supported ubuntu LTS, namely 18.04. I set up a VM with ubuntu 18.04 and ran the AppImage there and it worked, so I assumed it would work be fine.

Well, that'd be 20.04 at this time. And yes, that is the bare minimum required to pass the test. Not everyone runs exactly that though. So I am just trying to give helpful advice here.

FreeBSD? I thought AppImage was only for Linux! There actually is a FreeBSD port of lux in the graphics section.

I run AppImages on FreeBSD for testing from time to time. If they run there (using the Linuxulator; native speeds!) then I'm pretty confident they should be able to run on most Linux distributions ;-)

Do I understand that correctly: this change is to allow the unbundled AppImage to be run in the test environment? Fine with me. I'll change the AppRun. I was relying on APPDIR always being set, and I never tried to run the unbundled AppDir! I'll post again when I have the new AppImage online.

The automated test doesn't check for this (yet), but I inspected your AppImage manually. Currently you have no valid AppDir inside your AppImage. Luckily this is an easy fix.

[kfjahnke]

I've changed the AppRun script to follow your proposition above, and I'm now passing the GUI font via an environment variable (LUX_GUI_FONT) which I export in AppRun. This seems to work all right (tested on a VM with Ubuntu 18.04 and no extra installed packages). So now I'd like to ask you to reschedule the test yet again, and if you're happy with the outcome, to accept the lux Appimage into the catalog!
You said that the oldest still-supported Ubuntu is now 20.04 - should I move to that for building and testing? Or what else would you propose for maximum benefit?

[probonopd]

Thank you very much @kfjahnke