Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.3] Prometheus: Update speculative block metrics for produced blocks #957

Open
wants to merge 1 commit into
base: release/1.0
Choose a base branch
from
Open

[1.0.3] Prometheus: Update speculative block metrics for produced blocks #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/prometheus_plugin/metrics.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ struct catalog_type {
net_usage_us_produced_block.Increment(metrics.net_usage_us);

update(produced_metrics, metrics);
update(speculative_metrics, metrics);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay that this increments speculative num_blocks_created right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so. If we want to report produced blocks also as speculative, seems we should report all the values.


last_irreversible.Set(metrics.last_irreversible);
head_block_num.Set(metrics.head_block_num);
Expand Down