core-instrinctics, to core::mem::discriminant, but via the unsafe() mechanism

[mcr]

obiwan-[projects/trentonio/minerva-voucher](2.6.6) mcr 10683 %cargo build
   Compiling minerva-voucher v0.8.10 (/ssw/projects/trentonio/minerva-voucher)
warning: the feature `core_intrinsics` is internal to the compiler or standard library
   --> src/lib.rs:175:12
    |
175 | #![feature(core_intrinsics)]
    |            ^^^^^^^^^^^^^^^
    |
    = note: using it is strongly discouraged
    = note: `#[warn(internal_features)]` on by default

while reading: https://doc.rust-lang.org/core/mem/fn.discriminant.html
I tried to replace like:

        core::intrinsics::discriminant_value(self)

with:

core::mem::discriminant(self)

but that returns a Discriminant, and I don't think that is helpful.
Reading further down, there is the unsafe() call, which this patch switches to.
Maybe that's a regression, and your opinion is sought.

[j-devel]

I tried to replace like: core::intrinsics::discriminant_value(self) with core::mem::discriminant(self) but that returns a Discriminant, and I don't think that is helpful.

I agree. (related - https://users.rust-lang.org/t/enum-crimes-getting-the-discriminant/88103/10)

Reading further down, there is the unsafe() call, which this patch switches to.

Since each enum here already "opted-in to having a primitive representation" (#[repr(u64)] for enum Sid, #[repr(u8)] for enum Yang, #[repr(u8)] for enum Attr), I think we can just use the accessing technique described in that section like your patch does.