Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rss links #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include rss links #83

wants to merge 1 commit into from

Conversation

strk
Copy link

@strk strk commented May 21, 2020

Fixes #82

Copy link
Owner

@AngeloStavrow AngeloStavrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR! I really appreciate it.

My familiarity with feed auto-discovery is pretty minimal, so I have a question — how would this change affect a feed reader looking for an index.xml file on a path where no such file exists?

My gut tells me that we should provide such metadata only those paths that have an associated index.xml file, like /tags, /catgeories, and whatever's in the site.Params.mainSections array.

Comment on lines +13 to +14
<link rel="feed" type="application/rss+xml" href="./index.xml" title="{{ .Title }}" />
<link rel="alternate" type="application/rss+xml" href="./index.xml" title="{{ .Title }}" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that using ./index.html will allow for feed auto-discovery of /posts/index.xml, /tags/index.xml, etc.

Should there be some additional logic would be useful here to make sure that we exclude, for example, /pages/2 (which doesn't have an associated index.xml file)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, yes, It'd be better to only include a link where present. I don't know how to do that.

@AngeloStavrow AngeloStavrow added the wip Work in progress label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing rss link
2 participants