Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fixed clipping issue with cards on dashboard page #2035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/client/src/pages/dashboard/resumes/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ export const ResumesPage = () => {
</TabsList>
</div>

<ScrollArea className="h-[calc(100vh-140px)] lg:h-[calc(100vh-88px)]">
<ScrollArea
className="h-[calc(100vh-140px)] overflow-visible lg:h-[calc(100vh-88px)]"
allowOverflow={true}
>
<TabsContent value="grid">
<GridView />
</TabsContent>
Expand Down
7 changes: 6 additions & 1 deletion libs/ui/src/components/scroll-area.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@ export const ScrollArea = forwardRef<
React.ComponentPropsWithoutRef<typeof ScrollAreaPrimitive.Root> & {
hideScrollbar?: boolean;
orientation?: "vertical" | "horizontal";
allowOverflow?: boolean;
}
>(
(
{
type = "scroll",
orientation = "vertical",
hideScrollbar = false,
allowOverflow = false,
className,
children,
...props
Expand All @@ -26,7 +28,10 @@ export const ScrollArea = forwardRef<
className={cn("relative overflow-hidden", className)}
{...props}
>
<ScrollAreaPrimitive.Viewport className="size-full rounded-[inherit]">
<ScrollAreaPrimitive.Viewport
className="size-full rounded-[inherit]"
style={allowOverflow ? { overflowX: "visible", overflowY: "visible" } : {}}
>
{children}
</ScrollAreaPrimitive.Viewport>
<ScrollBar orientation={orientation} className={cn(hideScrollbar && "opacity-0")} />
Expand Down