Corrected resampling of precipitation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way of accumulating precipitation to daily values was incorrect (taking the max. of 00:00-23:00) and therefore overestimating the precipitation. It has been corrected now to take the max. of 01:00-00:00.
It is not used by the scripts but creates an error when trying to import as it is not provided in this repository. Furthermore, also tools has been adjusted to allow dates starting from 1950 to correspond to ERA5land_h2d_yearly.py
- Turned off proxy settings. - Adjusted one parameter name to match required ERA5-Land - Folder backslashes adjusted for Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sharing this useful repository! One major comment:
The current way of accumulating precipitation to daily values (taking the max. of 00:00-23:00) is incorrect and overestimates precipitation. If, for example, a dry day is followed by a rainy day, the code assigns for the dry day the value of 23:00 of the rainy day. In other words, the precipitation of the dry day is overwritten by almost the full precipitation amount of the wet day. Thus, the resampling in its current way overestimates the precipitation.
I have now corrected this to take the max. of 01:00-00:00, which makes sure that for each day the value of 00:00 (accumulation of the previous 24 hours) is chosen.
Thanks again and hope this helps!