Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rubocop TargetRubyVersion: 3.3 #537

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Bump rubocop TargetRubyVersion: 3.3 #537

merged 1 commit into from
Nov 7, 2024

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Nov 6, 2024 •
edited
Loading

Also, start upgrading syntax to use implicit variables in named parameters

Note, we could also bump rubocop related gems; but my environment cannot install ffi 1.15.5; so I'm a bit stuck touching Gemfile.lock

@drnic
Bump rubocop TargetRubyVersion: 3.3
1278855 
Also, start upgrading syntax to use implicit variables in named parameters
krschacht
krschacht approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@krschacht krschacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for this change! I haven't gotten used to these implicit params yet, but it's a good push. And I'm already liking the new one-line methods and it syntax in blocks. I love ruby. :)

@krschacht krschacht merged commit e7776ca into AllYourBot:main Nov 7, 2024
6 checks passed
@drnic drnic deleted the rubocop-3-3 branch November 10, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschacht krschacht krschacht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drnic @krschacht