Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bin/dev on Render #459

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Update bin/dev on Render #459

merged 1 commit into from
Jul 14, 2024

Conversation

krschacht
Copy link
Contributor

@krschacht krschacht commented Jul 14, 2024

After the recent PR #457, Render is now reporting an error Workaround: Overmind installing wrong binaries for aarch64-linux

This PR attempts to fixes the issue #458

@krschacht krschacht merged commit 86a31b9 into main Jul 14, 2024
6 checks passed
@krschacht krschacht deleted the bin-dev-render branch July 14, 2024 19:21
@htruong
Copy link
Contributor

htruong commented Jul 16, 2024

That's funny, why did the $RUBY_PLATFORM == aarch64-linux* match in the Render case?

On my laptop:

#!/bin/bash

RUBY_PLATFORM=$(ruby -e "puts Gem::Platform.local")

if [[ $RUBY_PLATFORM == aarch64-linux* ]]; then
        echo "$RUBY_PLATFORM is an aarch64-linux platform"
else
        echo "$RUBY_PLATFORM is not aarch64-linux"
fi
$ ./foo.sh
x86_64-linux is not aarch64-linux

Why did it match, did Render actually use aarch64-linux?

@krschacht
Copy link
Contributor Author

I was also confused by this. But notably, even if they are using it, I would have expected this change to have been a positive one for Render but instead bin/dev was exiting with an error code. It’s a bit of a sloppy fix but it worked to just exception it. There continue to be a surprising number of little edge cases for all these different environments! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants