[ACS-8694] Cleanup of visibility rules for extensions in ACA #4140

swapnil-verma-gl · 2024-09-25T07:27:59Z

JIRA ticket link or changeset's description

https://hyland.atlassian.net/browse/ACS-8694

Updated ACA extensions config to use array based visibility rules instead of string based. Also removed various unused rules

This is a breaking change

…rrays instead of single strings. Cleaned up rules in aca-content.module.ts

…otTrashcan()

…isibility

swapnil-verma-gl · 2024-09-26T08:25:58Z

This PR should not be merged to develop, before the merge of #4139 to this branch

docs/extending/rules.md

projects/aca-shared/rules/src/app.rules.spec.ts

AleksanderSklorz · 2024-10-10T12:26:39Z

Great work @swapnil-verma-gl with cleaning up of these rules :D

* [ACS-8694] Added migration guide * [ACS-8694] Fixed typo * [ACS-8694] Added missing rule migration. Fixed incorrect rule migration. Fixed typos

…n of rules list from rules-list.md. Added pointer to rules-list.md under tips section

sonarcloud · 2024-10-11T07:20:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

swapnil-verma-gl · 2024-10-11T08:20:42Z

This PR should not be merged to develop, before the merge of #4139 to this branch

#4139 merged to this branch. This PR can now be merged to develop after sufficient code review approvals. Removing 'Do not merge' label

swapnil-verma-gl added 19 commits September 18, 2024 11:37

[ACS-8694] Updated occurrences of visible in extensions.json to use a…

6cb4749

…rrays instead of single strings. Cleaned up rules in aca-content.module.ts

[ACS-8694] Removed extra commas

987232c

[ACS-8694] Broke down canDelete rule into seperate entities

0f4b24b

[ACS-8694] Fixed typo for notEmpty rule

64a0c3a

[ACS-8694] Fixed rule for edit offline

687e280

[ACS-8694] Updated extension.schema.json

743afbd

[ACS-8694] Updated extension.schema.json

0b1e8f6

[ACS-8694] Fixed rule for manage versions context menu item

f18dbb3

[ACS-8694] Fixed rule for manage versions and manage permissions

64cd59e

[ACS-8694] Added rules.canManageFolderRules

66b9d20

[ACS-8694] Fixed typo

5a31c92

[ACS-8694] Updated visibility rules for folder rules and AOS plugin

fcc3c78

[ACS-8694] Updated extension.schema.json

ca12e22

[ACS-8694] Updated existing rules to use !isTrashcan() instead of isN…

5a62619

…otTrashcan()

[ACS-8694] folder-rules.plugin.json now uses arrays for controlling v…

f13c024

…isibility

[ACS-8694] Updated app.extensions.schema

2c7571f

[ACS-8694] Removed unused rules

38d8c1f

[ACS-8694] Added unit tests for canToggleFileLock

7e9553b

[ACS-8694] Added rules-list.md

11759d1

swapnil-verma-gl requested review from DenysVuika and MichalKinas September 25, 2024 07:27

swapnil-verma-gl added the breaking change label Sep 25, 2024

swapnil-verma-gl added 2 commits September 26, 2024 11:25

[ACS-8694] Revert unneeded project.json change

0e6cd40

[ACS-8694] Fixed toggleEditOffline rule

abaf014

swapnil-verma-gl added the do not merge label Sep 26, 2024

swapnil-verma-gl marked this pull request as ready for review September 26, 2024 07:49