[ACS-8604][Legal Hold] [My Libraries] ADW - No warning when deleting Legal Hold #4069
Conversation
tamaragruszka
requested review from
AleksanderSklorz,
DaryaBalvanovich,
DenysVuika and
MichalKinas
| this.documentListService.reload(); | ||
| } | ||
| this.store.dispatch(new ShowLoaderAction(false)); | ||
| }); | ||
| } | ||
|
|
||
| showWarningOnHoldDeleteAction(nodes: NodeEntry[]): Observable<boolean> { |
There was a problem hiding this comment.
You're leaking the enterprise code to community edition.. ACA should know nothing about legal hold, this should only be a part of governance
There was a problem hiding this comment.
@MichalKinas I have similar issue, I understand your logic but it is our architecture, this logic is in ACA. I don't see any better solution without big refactor
There was a problem hiding this comment.
I need to agree with @MichalKinas here. Please provide other solution.
There was a problem hiding this comment.
@MateuszHY @MichalKinas the other solution is to cleanup this tech debt now, in 2018 when this part was written there was no awareness of something like legal hold will come in 2024. Refactor of current architecture is needed and it must be well thought. I agree that would be good not to provide new tech debt, but we must be aware it will be time consuming, then please plan it and we can keep this PR and mine as on hold then. I don't see a quick solution for that.
…arning-when-deleting-Legal-Hold
…arning-when-deleting-Legal-Hold
…arning-when-deleting-Legal-Hold
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8604
What is the new behaviour?
picking
deleteoption in context menu will show warningDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: