Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Use type_name instead of literals for LiteralType::parse #2500

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

[Chore] Use type_name instead of literals for LiteralType::parse #2500

wants to merge 2 commits into from

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Jun 19, 2024

A revival of #2459, as requested by @vicsn.

@ljedrz ljedrz force-pushed the refactor/futureproof_literals branch from 200006a to 23a0bad Compare June 25, 2024 09:54
@ljedrz ljedrz marked this pull request as ready for review June 25, 2024 09:54
raychu86
raychu86 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This change was already approved and merged previously, prior to revert.

@raychu86 raychu86 changed the title Use type_name instead of literals for LiteralType::parse [Chore] Use type_name instead of literals for LiteralType::parse Jul 8, 2024
@ljedrz
Copy link
Collaborator Author

ljedrz commented Jul 9, 2024

CI run link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raychu86 raychu86 raychu86 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljedrz @raychu86